Design Review #535

#535: Import Conditions

Opened Jul 12, 2020

Saluton TAG!

I'm requesting a TAG review of Import Conditions.

The Import Conditions and JSON modules proposal adds: An inline syntax for module import statements to pass on more information alongside the module specifier. An initial application for such attributes in supporting JSON modules in a common way across JavaScript environments.

Explainer¹ (minimally containing user needs and example code): https://github.com/tc39/proposal-import-conditions/blob/master/README.md
Specification URL: https://tc39.es/proposal-import-conditions, https://github.com/whatwg/html/pull/5658
Tests: we plan to write tests after HTML integration is agreed on and Stage 3 is reached
Security and Privacy self-review²: https://github.com/tc39/proposal-import-conditions/blob/master/tag-security-and-privacy.md
GitHub repo (if you prefer feedback filed there): https://github.com/tc39/proposal-import-conditions/issues
Primary contacts (and their relationship to the specification):
- Sven Sauleau (@xtuc), Babel
- Daniel Ehrenberg (@littledan), Igalia
- Myles Borins (@MylesBorins), GitHub
- Dan Clark (@dandclark), Microsoft
Organization(s)/project(s) driving the specification: Babel, Igalia, GitHub, Microsoft
Key pieces of existing multi-stakeholder review or discussion of this specification: https://github.com/whatwg/html/issues/5640, https://github.com/tc39/notes/blob/27b0afb98a2d212c24345dc101fa9803ba6e8377/meetings/2020-06/june-3.md#module-attributes-for-stage-2
External status/issue trackers for this specification (publicly visible, e.g. Chrome Status): https://github.com/mozilla/standards-positions/issues/373

Further details:

I have reviewed the TAG's API Design Principles
Relevant time constraints or deadlines: we are planning to ask Stage 3 at the July 2020 TC39 meeting (20th-23rd)
The group where the work on this specification is currently being done: TC39
The group where standardization of this work is intended to be done: TC39
Major unresolved issues with or opposition to this specification: determining whether the import conditions form part of the module map key.
This work is being funded by: Bloomberg for Igalia

We'd prefer the TAG provide feedback as:

💬 leave review feedback as a comment in this issue and @-notify @xtuc @littledan @MylesBorins @dandclark

Discussions

2020-08-03

Minutes

Tess: my very short review is it seems fine

Yves: use of types that are not media types is confusing... Otherwise it seems OK.

Tess: the string json is hard coded... into the spec... should have been media type json?

Yves: yes - a +JSON extension to the generic media type...

Peter: if you're going to use a specific media type it should be filtered to that media type... I like having just plain JSON but needs to be clearly defined what that maps to.

Yves: restricted set of types they are allowing...

Peter: we need to specify that the media type should be something+json...

Tess: what about text/plain? Some issue with web server configuration... as i read it: If you say type json it tries to parse it as json and if that parse fails it fails the import.

Peter: kind of scary to me that it relies as parsing. some stuff that isn't json could parse as json... I guess for json it's probably safe. More concerned about other things.

Tess: yes fair to be concerned about other cases...

Yves: more about the processing model of json rather than the type.

Yves: probably ok as it is.

Peter: yes probably.

Dan: we should close? I think any thing else we discussed could be handled by extensions down the road.

Tess: I can write a closing statement.

[agreed to close with thumbs-up]

Peter: Tag Ken in the issue [since he's not here this week and he's an assignee.]