#452: HTML horizontal review: Browsing contexts

Visit on Github.

Opened Dec 10, 2019

Subtask of w3ctag/design-reviews#412.

PRs to review:

  • whatwg/html#4284
  • whatwg/html#4350
  • whatwg/html#4366
  • whatwg/html#4379
  • whatwg/html#4402
  • whatwg/html#4430

Discussions

2020-03-16

Minutes

20 March 2020

Present: Dan & Tess

Tess: This cleans up and makes explicit a bunch of stuff around browsing context creation. Nothing architectural here.

Dan: OK.

Tess: related browsing contexts have associated documents that are cross-origin from eachother. baz.com (in the window that got window.opened) knows that the opener was foo.com even if foo.com originally opened bar.com ... The previous wording was unclear. this change is a fairly big text change that clarifies that and cleans up some of the terminology. The change clarifies things that were true but not clear before and also simplifies the naming of some of these concepts. So probably no architectural implications although it is a change for specs that rely on this spec.

Dan: OK

Tess: This is a bug fix. It exposed some weirdness that got resolved in a future change, so this one itself doesn't have any architectural issues.

Dan: Anything architectural here?

Tess: it's possible to cause a window to open not from a current browsing context. E.g. A service worker can open a window. And if there isn't a current browser context at all, and a window is opened programatically, normally the window would have an opener but there is no context that created it to point at. It's a bug fix.

Dan: it clarifies.

Tess: there is a follow-up that got filed from this because this change exposed an inconsistency,

Tess: this is cleanup. it clarified some things - as a result, some browser bugs got filed – as the previous text was unclear.

Tess: if the window has a toolbar – toolbars only exist for the lifetime of a window. This makes that clear. No concern here.

Dan: LGTM

Summary

[So we reviewed all of these and found no issues.

2020-03-16

Minutes

Dan: a bunch of WHATWG PRs to review.

Tess: Haven't taken a look yet. We've been pretty good at using face-to-face breakout time for these. Should we do a one-off breakout together this week?

(will take scheduling offline