#316: IndexedDB Transaction Explicit Commit API

Visit on Github.

Opened Oct 30, 2018

こんにちはTAG!

I'm requesting a TAG review of:

Further details (optional):

  • Relevant time constraints or deadlines: Preferably before the end of this quarter.
  • I have reviewed the TAG's API Design Principles

We'd prefer the TAG provide feedback as (please select one):

  • open issues in our Github repo for each point of feedback
  • open a single issue in our Github repo for the entire review
  • leave review feedback as a comment in this issue and @-notify [github usernames]

Discussions

2019-01-15

Minutes

Kenneth: Well, it's one function! Has a good explainer. Originally, IDB is auto-committing. This will allow folks to commit when folks want it to be commitment; it will still auto-commit but will be later. There is some bikeshedding on the name, since it could be misunderstood.

Alex: Does impact the conversation about retro-fitting IDB into Promise. IDB auto-close was end of micro-task or task; so I don't see this as really controversial. Does anyone have data that shows this can really increase throughput?

Kenneth: No one has brought this up with me. Folks may think that they may need to call "commit".

Alex: Can I call "commit" twice? I would like to see example code that covers the error conditions/handling? Otherwise, this is a very very good explainer!

Dan: Kenneth, you can leave some feedback on the issue?

Kenneth: Yes, and I want to sync with Sangwhan too.

2019-01-22

Minutes

Kenneth: We finished this last week?

Sangwhan: Our main point of feedback was there was 'commit' and we wanted to call it 'forcecommit'? I'm OK with either one. Looked over a variety of other APIs in other platforms...

Kenneth: not all platforms do auto-commit though right?

Sangwhan: It depends :-)

Kenneth: will leave an addition comment.